Core: use patch extension register directly #4375
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tials
could use something like "".join(file.rpartition(".")[1:]) if we still don't want os loaded
also i left in the iteration option in case there's an edge case I don't know about, tested a bizhawk game without it and had no issue
github-actions
bot
added
affects: core
|
looks like pathlib may also be an option, no clue the pro/cons for these options |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
use existing patch extension register instead of iterating over potentials
could use something like
"".join(file.rpartition(".")[1:])if we still don't want os loaded also i left in the iteration option in case there's an edge case I don't know about, tested a bizhawk game without it and had no issueHow was this tested?
opened up a bizhawk game by patch
If this makes graphical changes, please attach screenshots.